Skip to content

fix(@angular/build): inject testing polyfills in Karma unit-test executor #32046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clydin merged 1 commit into from
Dec 5, 2025
Merged

fix(@angular/build): inject testing polyfills in Karma unit-test executor #32046

clydin merged 1 commit into from
Dec 5, 2025

Conversation

@clydin
Copy link
Member

@clydin clydin commented Dec 5, 2025

This commit ensures that testing polyfills (specifically zone.js/testing) are correctly injected when using the new unit-test builder with the Karma runner. Previously, only the application polyfills were included, which could lead to runtime errors in tests dependent on zone.js/testing.

Closes #32032

@clydin
fix(@angular/build): inject testing polyfills in Karma unit-test exec…
43e0696 
…utor

This commit ensures that testing polyfills (specifically `zone.js/testing`) are correctly injected when using the new unit-test builder with the Karma runner. Previously, only the application polyfills were included, which could lead to runtime errors in tests dependent on `zone.js/testing`.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Dec 5, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 5, 2025
@clydin clydin requested a review from alan-agius4 December 5, 2025 17:16
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 5, 2025
@clydin clydin merged commit 385165c into angular:main Dec 5, 2025
38 checks passed
@clydin
Copy link
Member Author

clydin commented Dec 5, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@clydin clydin deleted the unit-test/karma-zone-polyfills branch December 5, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@angular/build:unit-test: inject zone.js/testing before karma builder execution

2 participants

@clydin @alan-agius4