Skip to content

test: rename npm E2E suite to webpack #32072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Dec 9, 2025
Merged

test: rename npm E2E suite to webpack #32072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
matrix:
os: [ubuntu-latest]
node: [20, 22, 24]
subset: [npm, esbuild]
subset: [esbuild, webpack]
shard: [0, 1, 2, 3, 4, 5]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
matrix:
os: [windows-2025]
node: [22]
subset: [npm, esbuild]
subset: [esbuild, webpack]
shard: [0, 1, 2, 3, 4, 5]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
matrix:
os: [ubuntu-latest]
node: [22]
subset: [npm, esbuild]
subset: [esbuild, webpack]
shard: [0, 1, 2, 3, 4, 5]
runs-on: ${{ matrix.os }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
matrix:
os: [ubuntu-latest]
node: [22]
subset: [npm, esbuild]
subset: [esbuild, webpack]
shard: [0, 1, 2, 3, 4, 5]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -203,7 +203,7 @@ jobs:
matrix:
os: [ubuntu-latest]
node: [22]
subset: [npm, esbuild]
subset: [esbuild, webpack]
shard: [0, 1, 2, 3, 4, 5]
runs-on: ${{ matrix.os }}
steps:
Expand Down
9 changes: 6 additions & 3 deletions tests/legacy-cli/e2e.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,14 @@ def e2e_suites(name, runner, data):
# Default target meant to be run manually for debugging, customizing test cli via bazel
_e2e_tests(name + "_" + toolchain_name, runner, data = data, toolchain = toolchain, tags = ["manual"])

_e2e_suite(name, runner, "npm", data, toolchain_name, toolchain)
# Main test suites
_e2e_suite(name, runner, "webpack", data, toolchain_name, toolchain)
_e2e_suite(name, runner, "esbuild", data, toolchain_name, toolchain)

# Package manager subsets
_e2e_suite(name, runner, "bun", data, toolchain_name, toolchain)
_e2e_suite(name, runner, "pnpm", data, toolchain_name, toolchain)
_e2e_suite(name, runner, "yarn", data, toolchain_name, toolchain)
_e2e_suite(name, runner, "esbuild", data, toolchain_name, toolchain)

# Saucelabs tests are only run on the default toolchain
_e2e_suite(name, runner, "saucelabs", data)
Expand Down Expand Up @@ -162,7 +165,7 @@ def _e2e_suite(name, runner, type, data, toolchain_name = "", toolchain = None):
args.append("--esbuild")
tests = BROWSER_TESTS
ignore = None
elif type == "npm":
elif type == "webpack":
tests = None
ignore = BROWSER_TESTS + WEBPACK_IGNORE_TESTS

Expand Down