Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Dec 10, 2025

This change removes the use of ts-node to execute both ng-dev and the repo dev scripts. Due to the use of enums imports from @angular/cli package code for the analytics validation, the admin package script currently requires the --experimental-transform-types option.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 10, 2025
@clydin clydin force-pushed the build/node-ts-support branch 2 times, most recently from 34d1ed9 to 1e1fba9 Compare December 10, 2025 15:56
@clydin clydin marked this pull request as ready for review December 10, 2025 16:13
@clydin clydin added the target: minor This PR is targeted for the next minor release label Dec 10, 2025
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Dec 10, 2025
This change removes the use of `ts-node` to execute both `ng-dev` and
the repo dev scripts. Due to the use of enums imports from `@angular/cli`
package code for the analytics validation, the `admin` package script
currently requires the `--experimental-transform-types` option.
@clydin clydin merged commit 85c6e39 into angular:main Dec 10, 2025
35 checks passed
@clydin
Copy link
Member Author

clydin commented Dec 10, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@clydin clydin deleted the build/node-ts-support branch December 10, 2025 19:12
dgp1130 added a commit to dgp1130/angular-cli that referenced this pull request Dec 18, 2025
This got dropped in angular#32088, but is needed because the release process calls `pnpm run ng-dev`, which requires a script to exist. Meanwhile `pnpm ng-dev` does not.
dgp1130 added a commit that referenced this pull request Dec 18, 2025
This got dropped in #32088, but is needed because the release process calls `pnpm run ng-dev`, which requires a script to exist. Meanwhile `pnpm ng-dev` does not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants