perf(@angular/build): fix memory leak in ng serve with i18n#32599
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Feb 26, 2026
Merged
perf(@angular/build): fix memory leak in ng serve with i18n#32599alan-agius4 merged 1 commit intoangular:mainfrom
ng serve with i18n#32599alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
When running `ng serve` with i18n configured, every file save (.html files) triggers a rebuild that creates a new piscina `ThreadPool` for `i18n-inline-worker.js`. Old pools and their worker threads were not properly cleaned up because the inliner was closed prematurely, causing unbounded memory growth. This commit ensures that the inliner is kept open while processing template updates, resolving the issue where orphaned threads were created. Closes angular#32584
alan-agius4
added
action: review
1 task
angular-robot
bot
added
area: performance
clydin
approved these changes
Feb 26, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
ng servewith i18n configured, every file save (.html files) triggers a rebuild that creates a new piscinaThreadPoolfori18n-inline-worker.js. Old pools and their worker threads were not properly cleaned up because the inliner was closed prematurely, causing unbounded memory growth.This commit ensures that the inliner is kept open while processing template updates, resolving the issue where orphaned threads were created.
Closes #32584