Skip to content

build: update dependency aspect_rules_jasmine to v2.0.4 (21.2.x)#32667

Merged
clydin merged 1 commit intoangular:21.2.xfrom
angular-robot:ng-renovate/21.2.x-bazel-dependencies
Mar 4, 2026
Merged

build: update dependency aspect_rules_jasmine to v2.0.4 (21.2.x)#32667
clydin merged 1 commit intoangular:21.2.xfrom
angular-robot:ng-renovate/21.2.x-bazel-dependencies

Conversation

@angular-robot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
aspect_rules_jasmine bazel_dep patch 2.0.32.0.4

  • If you want to rebase/retry this PR, check this box

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Mar 3, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine patch version update for the aspect_rules_jasmine dependency. This ensures the project benefits from the latest bug fixes and minor improvements in the testing rules, maintaining compatibility and stability within the Bazel build system.

Highlights

  • Dependency Update: The aspect_rules_jasmine dependency has been updated from version 2.0.3 to 2.0.4.
  • Bazel Lock File Update: The MODULE.bazel.lock file was updated to reflect the new version and associated content hashes for aspect_rules_jasmine, along with an updated telemetry digest.
Changelog
  • MODULE.bazel
    • Updated the aspect_rules_jasmine dependency to version 2.0.4.
  • MODULE.bazel.lock
    • Updated the locked version and content hashes for aspect_rules_jasmine to 2.0.4.
    • Adjusted the usagesDigest for aspect_tools_telemetry.
Activity
  • This pull request was automatically generated by the Renovate bot (angular-robot) to update a dependency.
  • The PR description includes a checkbox for rebase/retry, indicating automated maintenance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the aspect_rules_jasmine dependency to version 2.0.4. The changes are generally correct, but I've found a small issue in MODULE.bazel.lock where the old dependency version is not cleanly removed. I've provided a suggestion to fix this for better maintainability of the lock file.

Comment on lines 24 to -25
"https://bcr.bazel.build/modules/aspect_rules_jasmine/2.0.3/MODULE.bazel": "1c2e7a2908dbf6640dce9b242369cf48b7018af666485cbae1470b49a9672591",
"https://bcr.bazel.build/modules/aspect_rules_jasmine/2.0.3/source.json": "5619d28f3e99eca53a0ae077cff6c66966d2da2ee8621bc0542af3fb85df128f",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It seems the update to 2.0.4 didn't fully remove the entries for the old version 2.0.3. To keep the lock file clean, both MODULE.bazel and source.json entries for 2.0.3 should be removed and replaced by the new version's entries.

    "https://bcr.bazel.build/modules/aspect_rules_jasmine/2.0.4/MODULE.bazel": "fbb819eb8b7e5d7f67fdd38f7cecb413e287594cd666ce192c72c8828527775a",
    "https://bcr.bazel.build/modules/aspect_rules_jasmine/2.0.4/source.json": "81ffb708333cd98ec3c0b4cc004f4d5cf92a16914b5196a2892c45141bba7cff",

@clydin clydin merged commit a6d5f33 into angular:21.2.x Mar 4, 2026
37 checks passed
@clydin
Copy link
Member

clydin commented Mar 4, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@angular-robot angular-robot deleted the ng-renovate/21.2.x-bazel-dependencies branch March 4, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants