Skip to content

test: update tests to handle regexp to be case insensitive#32723

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:regexp-test
Mar 9, 2026
Merged

test: update tests to handle regexp to be case insensitive#32723
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:regexp-test

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 marked this pull request as ready for review March 9, 2026 13:52
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 9, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates regular expressions in the test suite to be case-insensitive when matching <script> tags. This improves the robustness of the tests. The changes are correct and address the intended goal. I have no further comments on the changes presented in this pull request.

@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 9, 2026
@alan-agius4 alan-agius4 merged commit a09f27a into angular:main Mar 9, 2026
39 checks passed
@alan-agius4 alan-agius4 deleted the regexp-test branch March 9, 2026 14:45
@alan-agius4
Copy link
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants