feat(@schematics/angular): rely on strict template default in generated workspaces#32824
Merged
alan-agius4 merged 2 commits intoangular:mainfrom Mar 24, 2026
Merged
feat(@schematics/angular): rely on strict template default in generated workspaces#32824alan-agius4 merged 2 commits intoangular:mainfrom
alan-agius4 merged 2 commits intoangular:mainfrom
Conversation
alan-agius4
added
action: review
angular-robot
bot
added
detected: feature
…ed workspaces Since strict templates are now the default in the Angular compiler, this change removes the explicit "strictTemplates": true setting when creating a new strict workspace. We now only explicitly set "strictTemplates": false when the workspace is created with --strict=false to maintain consistent behavior for non-strict setups. See: angular/angular#67802
alan-agius4
force-pushed
the
strict-template
branch
from
caa6a7a to
ba5fe7b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the tsconfig.json.template to reflect the Angular compiler's new default behavior for strictTemplates. It removes the explicit strictTemplates: true setting when a strict workspace is generated, and instead explicitly sets strictTemplates: false only when --strict=false is provided. The associated test cases in index_spec.ts have been updated to align with these changes. I've identified an opportunity to improve the test coverage for the strict: true scenario by adding assertions for other angularCompilerOptions that are explicitly set.
…generated workspaces
clydin
approved these changes
Mar 24, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since strict templates are now the default in the Angular compiler, this change removes the explicit "strictTemplates": true setting when creating a new strict workspace. We now only explicitly set "strictTemplates": false when the workspace is created with --strict=false to maintain consistent behavior for non-strict setups.
See: angular/angular#67802