fix(@angular/cli): handle missing package manager during analytics initialization#32929
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
fix(@angular/cli): handle missing package manager during analytics initialization#32929clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
clydin
added
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces error handling when retrieving the package manager version for analytics by wrapping the call in a try-catch block. A review comment points out that the version is now fetched even when analytics are disabled, which introduces unnecessary performance overhead by spawning a sub-process needlessly; it is recommended to move this logic inside the conditional check for the user ID.
…itialization Wrap getVersion() call in try-catch to prevent a crash during analytics setup when the package manager is not available.
clydin
force-pushed
the
analytics/safe-pm-version
branch
from
97ffd2d to
8d8a710
Compare
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap getVersion() call in try-catch to prevent a crash during analytics setup when the package manager is not available.