fix(@angular/build): use rootDir for HMR component updates path resolution#33016
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 17, 2026
Merged
fix(@angular/build): use rootDir for HMR component updates path resolution#33016alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
…ution Use `compilerOptions.rootDir` when calculating the relative path for HMR component updates, falling back to the current directory if not set. This ensures correct path resolution when `rootDir` is configured in `tsconfig`. Closes angular#33005 and closes angular#32998
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the path resolution logic in the AotCompilation class to prioritize the rootDir from compiler options when calculating relative paths for components. I have no feedback to provide as there were no review comments to evaluate.
alan-agius4
added
action: review
clydin
reviewed
Apr 17, 2026
| const componentFilename = node.getSourceFile().fileName; | ||
| let relativePath = relative(host.getCurrentDirectory(), componentFilename); | ||
| let relativePath = relative( | ||
| compilerOptions.rootDir ?? host.getCurrentDirectory(), |
Member
There was a problem hiding this comment.
Is compilerOptions.rootDir absolute here?
Collaborator
Author
There was a problem hiding this comment.
Yes, it's always fully resolved by tsc.
clydin
approved these changes
Apr 17, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
compilerOptions.rootDirwhen calculating the relative path for HMR component updates, falling back to the current directory if not set. This ensures correct path resolution whenrootDiris configured intsconfig.Closes #33005 and closes #32998