fix(@angular-devkit/build-angular): fix app-shell route format and improve package resolution#33017
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 17, 2026
Merged
Conversation
improve package resolution - In the `app-shell` builder, ensure the route URL has a leading slash. - In webpack helpers, use `createRequire` in `isPackageInstalled` to improve package resolution robustness.
alan-agius4
added
the
action: review
alan-agius4
changed the title
alan-agius4
added
the
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the app-shell builder to ensure routes are correctly prefixed with a slash and refactors the package installation check to use createRequire for module resolution. Review feedback identifies a potential bug where an undefined route would result in the string "/undefined" and recommends using path.resolve for more robust cross-platform path handling when creating a require instance.
clydin
approved these changes
Apr 17, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve package resolution
app-shellbuilder, ensure the route URL has a leading slash.createRequireinisPackageInstalledto improve package resolution robustness.