fix(@schematics/angular): add missing imports for focus and skip APIs in refactor-jasmine-vitest#33034
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 23, 2026
Conversation
hawkgs
added
type: bug/fix
area: @schematics/angular
action: review
hawkgs
force-pushed
the
schematics/fix-refactor-jasmine-vitest-missing-imports
branch
from
a03671c to
6c04085
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Jasmine-to-Vitest transformer to correctly handle imports for focused and skipped tests by introducing a mapping for functions like fdescribe and xit. It also adds corresponding unit tests. The review feedback recommends using a Map instead of a plain object for the lookup table to avoid prototype-related issues and ensure consistency with the rest of the file.
… in refactor-jasmine-vitest `xdescribe`, `fdescribe`, `xit` and `fit` Vitest equivalents use a slightly different API. This change handles the `--add-imports` aspect where the appropriate functions are imported for these specific APIs. Fixes angular#33021
hawkgs
force-pushed
the
schematics/fix-refactor-jasmine-vitest-missing-imports
branch
from
6c04085 to
7026e78
Compare
clydin
approved these changes
Apr 22, 2026
alan-agius4
added
target: patch
Collaborator
hawkgs
deleted the
schematics/fix-refactor-jasmine-vitest-missing-imports
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xdescribe,fdescribe,xitandfitVitest equivalents use a slightly different API. This change handles the--add-importsaspect where the appropriate functions are imported for these specific APIs.Fixes #33021