Skip to content

docs: reference vitest-base config#33054

Open
itsdevdom wants to merge 2 commits intoangular:mainfrom
itsdevdom:bugfix/runner-config-docs
Open

docs: reference vitest-base config#33054
itsdevdom wants to merge 2 commits intoangular:mainfrom
itsdevdom:bugfix/runner-config-docs

Conversation

@itsdevdom
Copy link
Copy Markdown

@itsdevdom itsdevdom commented Apr 26, 2026

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Current documentation mistakenly still references vitest.config.ts as an example to apply Vite config customizations.

What is the new behavior?

Documentation now references the correct vitest-base.config.ts as an example to apply Vite config customizations, both in the unit test schema and the Karma-to-Vite migration message.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default Vitest configuration filename from vitest.config.ts to vitest-base.config.ts within the unit-test builder schema and the Karma-to-Vitest migration schematic. Feedback was provided to improve the migration warning message by explicitly mentioning the need to enable the runnerConfig option and refining the formatting of the file reference.

Comment thread packages/schematics/angular/migrations/migrate-karma-to-vitest/karma-processor.ts Outdated
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Apr 27, 2026
@alan-agius4
Copy link
Copy Markdown
Collaborator

alan-agius4 commented Apr 27, 2026

Can you also please update the commit type to docs

@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 27, 2026
@itsdevdom itsdevdom force-pushed the bugfix/runner-config-docs branch from 9b82c83 to e60880c Compare April 27, 2026 15:14
@itsdevdom itsdevdom changed the title fix: reference vitest-base config docs: reference vitest-base config Apr 27, 2026
@angular-robot angular-robot Bot added the area: docs Related to the documentation label Apr 27, 2026
@itsdevdom itsdevdom force-pushed the bugfix/runner-config-docs branch from e60880c to d619279 Compare April 27, 2026 15:16
@itsdevdom
Copy link
Copy Markdown
Author

Commit type and PR title are now docs.

Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build area: docs Related to the documentation area: @schematics/angular target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants