docs: reference vitest-base config#33054
Open
itsdevdom wants to merge 2 commits intoangular:mainfrom
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the default Vitest configuration filename from vitest.config.ts to vitest-base.config.ts within the unit-test builder schema and the Karma-to-Vitest migration schematic. Feedback was provided to improve the migration warning message by explicitly mentioning the need to enable the runnerConfig option and refining the formatting of the file reference.
Collaborator
|
Can you also please update the commit type to |
9b82c83 to
e60880c
Compare
…itest migration warning
…a runnerConfig description
e60880c to
d619279
Compare
Author
|
Commit type and PR title are now |
alan-agius4
approved these changes
Apr 27, 2026
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current documentation mistakenly still references
vitest.config.tsas an example to apply Vite config customizations.What is the new behavior?
Documentation now references the correct
vitest-base.config.tsas an example to apply Vite config customizations, both in the unit test schema and the Karma-to-Vite migration message.Does this PR introduce a breaking change?
Other information