build: update pnpm to v10.33.4 (main)#33155
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pnpm version from 10.33.2 to 10.33.4 in both MODULE.bazel and package.json. A review comment identifies a critical omission: the pnpm-lock.yaml file was not updated. This update is necessary to maintain consistency and security, especially since the new pnpm version introduces changes to how git-hosted dependencies are handled in the lockfile.
| "url": "git+https://github.com/angular/angular-cli.git" | ||
| }, | ||
| "packageManager": "pnpm@10.33.2", | ||
| "packageManager": "pnpm@10.33.4", |
There was a problem hiding this comment.
The pnpm-lock.yaml file is missing from this pull request. Updating pnpm to 10.33.4 (especially with the packageManager field change) typically requires a corresponding update to the lockfile. This is particularly important for this release as it introduces integrity pinning for git-hosted dependencies (like @angular/ng-dev on line 57) and a new gitHosted: true field in the lockfile. Please ensure the lockfile is updated and included to maintain consistency and security.
See associated pull request for more information.
b44a04b to
a0beac1
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This PR contains the following updates:
10.33.2→10.33.4Release Notes
pnpm/pnpm (pnpm)
v10.33.4: pnpm 10.33.4Compare Source
Patch Changes
Pin the integrity of git-hosted tarballs (codeload.github.com, gitlab.com, bitbucket.org) in the lockfile so that subsequent installs detect a tampered or substituted tarball and refuse to install it. Previously the lockfile only stored the tarball URL for git dependencies, so a compromised git host or a man-in-the-middle could serve arbitrary code on later installs without lockfile changes.
A new
gitHosted: truefield is recorded on git-hosted tarball resolutions in the lockfile, letting every reader/writer route them by a single typed check instead of pattern-matching the tarball URL in each call site. Lockfiles written by older pnpm versions are enriched on load (URL fallback) so the field can be relied on uniformly across the codebase.Fix a regression where
pnpm --recursive --filter '!<pkg>' run/exec/test/addwould include the workspace root in the matched projects. The workspace root is now correctly excluded by default when only negative--filterarguments are provided, matching the documented behavior. To include the root, pass--include-workspace-root#11341.Platinum Sponsors
Gold Sponsors
v10.33.3: pnpm 10.33.3Compare Source
Patch Changes
@pnpm/exeto v11+ on Intel macOS (darwin-x64),pnpm self-updatenow transparently switches to the JS-onlypnpmpackage on npm instead of installing@pnpm/exe@v11+(which doesn't ship a working binary for Intel Macs because of an upstream Node.js SEA bug — see #11423 and nodejs/node#62893). Without this, the self-update would silently leave the user with no workingpnpmbinary. The new install requires Node.js to be available onPATH; a warning is printed when the swap happens. All other host/version combinations are unchanged.pnpm self-update(with no version argument) no longer downgrades pnpm when the registry'slatestdist-tag points to an older release than the currently active version. Runpnpm self-update latestto force a downgrade #11418.Platinum Sponsors
Gold Sponsors