fix(@angular/ssr): support all X-Forwarded-* headers when trustProxyHeaders is true#33170
Open
alan-agius4 wants to merge 1 commit into
Open
fix(@angular/ssr): support all X-Forwarded-* headers when trustProxyHeaders is true#33170alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
alan-agius4
force-pushed
the
proxy-headers
branch
2 times, most recently
from
5d7dfa1 to
dd9e29e
Compare
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the proxy header validation logic in the Angular SSR package. It replaces the fixed list of X-Forwarded-* headers with a wildcard sentinel string (ɵ*) when trustProxyHeaders is enabled, effectively allowing all proxy headers to be trusted. The corresponding tests were updated to use the normalizeTrustProxyHeaders utility and verify that additional headers are now correctly handled. I have no feedback to provide.
alan-agius4
added
target: rc
…eaders is true Previously, setting `trustProxyHeaders: true` only allowed a predefined set of common proxy headers (such as `x-forwarded-for` and `x-forwarded-host`). This resulted in warning logs when requests contained other valid proxy headers like `x-forwarded-client-cert` or `x-forwarded-email`. Closes angular#33169
alan-agius4
force-pushed
the
proxy-headers
branch
from
dd9e29e to
0aeebba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, setting
trustProxyHeaders: trueonly allowed a predefined set of common proxy headers (such asx-forwarded-forandx-forwarded-host). This resulted in warning logs when requests contained other valid proxy headers likex-forwarded-client-certorx-forwarded-email.Closes #33169