fix(@schematics/angular): fix browserMode option mapping in refactor-jasmine-vitest#33314
Merged
Merged
Conversation
…jasmine-vitest The jasmine-vitest refactor schematic previously mapped the `browserMode` option to `options.browerMode` (with a spelling typo). Because of the index signature `[property: string]: any` in the generated options Schema type, the compiler did not emit any error, which resulted in the option silently resolving to `undefined` at runtime and disabling browser-mode transformations.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a typo in the jasmine-vitest schematic where options.browerMode was incorrectly used instead of options.browserMode. It also adds corresponding unit tests to verify the behavior of toHaveClass transformations based on the browserMode option. There are no review comments, so I have no feedback to provide.
alan-agius4
approved these changes
Jun 5, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jasmine-vitest refactor schematic previously mapped the
browserModeoption tooptions.browerMode(with a spelling typo). Because of the index signature[property: string]: anyin the generated options Schema type, the compiler did not emit any error, which resulted in the option silently resolving toundefinedat runtime and disabling browser-mode transformations.