chore(docs): update bootstrap documentation #4115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
reviewed
Jan 19, 2017
Contributor
Brocco
left a comment
Brocco
left a comment
There was a problem hiding this comment.
Looks good, I like the organizational changes, just one minor change.
| ```sass | ||
| // version 3 | ||
| @import '_variables'; | ||
| @import '../node_modules/bootstrap-sass/assets/stylesheets/_bootstrap.scss'; |
Contributor
There was a problem hiding this comment.
Remove the file extension here.
Contributor
Author
There was a problem hiding this comment.
Good catch. Fixed. 😄
delasteve
force-pushed
the
chore/bootstrap-sass
branch
from
c2d7cae to
4166455
Compare
Brocco
approved these changes
Jan 19, 2017
delasteve
force-pushed
the
chore/bootstrap-sass
branch
from
4166455 to
5d1cb50
Compare
cacogr
reviewed
Jan 20, 2017
|
|
||
| ```sass | ||
| // version 3 | ||
| @import '_variables'; |
There was a problem hiding this comment.
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#partials
underscore not needed for @import
delasteve
force-pushed
the
chore/bootstrap-sass
branch
from
5d1cb50 to
c951c17
Compare
delasteve
force-pushed
the
chore/bootstrap-sass
branch
from
c951c17 to
9b23880
Compare
This was referenced Jan 22, 2017
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.