fix(@angular/cli): allow backticks in templateUrl and styleUrls#8666
fix(@angular/cli): allow backticks in templateUrl and styleUrls#8666filipesilva merged 1 commit intoangular:masterfrom
Conversation
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
Heya, I think the change looks good, but could you do the test as a unit test in https://github.com/angular/angular-cli/blob/master/packages/@ngtools/webpack/src/transformers/replace_resources.spec.ts please? It's just a matter of making it faster, the e2e tests take longer.
Thanks for taking this on btw!
DetectiveQuack
force-pushed
the
templateStyleUrls
branch
from
c21ed02 to
997a017
Compare
|
No worries, I have updated the PR with the requested changes @filipesilva |
| if (element.kind == ts.SyntaxKind.StringLiteral) { | ||
| if ( | ||
| element.kind === ts.SyntaxKind.StringLiteral || | ||
| element.kind === ts.SyntaxKind.FirstTemplateToken |
There was a problem hiding this comment.
This is wrong, it should be ts.SyntaxKind.NoSubstitutionTemplateLiteral. You're not getting the last position of the template token correctly in this case. We probably don't want substitutions in the URLs.
There was a problem hiding this comment.
My mistake, I have made the relevant changes @hansl
DetectiveQuack
force-pushed
the
templateStyleUrls
branch
from
997a017 to
8e93d02
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
resolves #7945