Skip to content

fix(@angular/cli): allow TS 2.5 for Angular >= 5.1 #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(@angular/cli): allow TS 2.5 for Angular >= 5.1 #8766

wants to merge 1 commit into from

Conversation

@cyrilletuzi
Copy link
Contributor

@cyrilletuzi cyrilletuzi commented Dec 6, 2017

@CaerusKaru CaerusKaru mentioned this pull request Dec 7, 2017
Closed
@cexbrayat cexbrayat mentioned this pull request Dec 7, 2017
Closed
@cexbrayat
Copy link
Member

cexbrayat commented Dec 7, 2017

Fixes #8768

filipesilva
filipesilva previously approved these changes Dec 7, 2017
View reviewed changes
@filipesilva
Copy link
Contributor

filipesilva commented Dec 7, 2017

LGTM, was just putting up a PR for this right now. Unsure what's happening with CI, looking into it.

@cyrilletuzi
Copy link
Contributor Author

cyrilletuzi commented Dec 7, 2017

The PR was done before #8765 was fixed, maybe the source of CI error ?

@Brocco
Copy link
Contributor

Brocco commented Dec 7, 2017

@cyrilletuzi Can you please rebase this PR? There have been a few fixes since you created your PR. Thanks!

@cyrilletuzi
fix(@angular/cli): set tslint 5 to emit warnings
2077acb 
fix(@angular/cli): set tslint 5 to emit warnings

cli 1.1.0 upgraded to tslint 5, but tslint 5 is now raising errors by default, instead of warnings previously, and it's very confusing (lint errors can't be on the same level as syntax errors).
@cyrilletuzi
Copy link
Contributor Author

cyrilletuzi commented Dec 7, 2017

Sorry, I had to redo this in #8792

Don't even know how the last operation has been possible, so I've started from start to clean my git history.

@cyrilletuzi cyrilletuzi closed this Dec 7, 2017
@JinsPeter
Copy link

JinsPeter commented Dec 11, 2017 •
edited
Loading

When can npm install @angular/compiler-cli@5.1.0 reflect this warning fix

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@filipesilva filipesilva filipesilva left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyrilletuzi @cexbrayat @filipesilva @Brocco @JinsPeter @googlebot