Skip to content

fix(@angular/cli): avoid defaulting base-href to an empty string#9410

Merged
filipesilva merged 1 commit intoangular:masterfrom
clydin:fix-serve-base-href
Jan 29, 2018
Merged

fix(@angular/cli): avoid defaulting base-href to an empty string#9410
filipesilva merged 1 commit intoangular:masterfrom
clydin:fix-serve-base-href

Conversation

@clydin
Copy link
Member

@clydin clydin commented Jan 27, 2018

Fixes #9401
Fixes #9297

@filipesilva filipesilva merged commit a40e801 into angular:master Jan 29, 2018
@sbologescu
Copy link

I applied the fix for 9410 manually on my local, and while the behavior improved so that the browser refreshes the proper route on code changes, I noticed that my fontawesome path is still incorrect causing the icons on the page to be broken after a refresh.
For example, navigating from project root to a route like https://localhost:4200/[some_route] will cause fontawesome to be loaded correctly from the basehref (https://localhost:4200/fontawesome[hash]).
However, if you refresh the above route (or change code to cause a refresh), the browser will incorrectly try to retrieve fontawesome from https://localhost:4200/[some_route]/fontawesome[hash]

Thank you and regards,
Seb

@clydin clydin deleted the fix-serve-base-href branch February 19, 2018 18:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Routing not working properly while using ng serve (1.7.0-beta.2) ng serve reloads fail with cli 1.7.0 beta

4 participants