Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Trans(docs/*/latest/*/_data.json)#22

Merged
byungjune merged 3 commits intoangular:masterfrom
byungjune:master
Jan 10, 2017
Merged

Trans(docs/*/latest/*/_data.json)#22
byungjune merged 3 commits intoangular:masterfrom
byungjune:master

Conversation

@byungjune
Copy link
Contributor

  • Trans(docs/ts/latest/_data.json)
  • Trans(docs/js/latest/_data.json)
  • Trans(docs/ts/latest/tutorial/_data.json)

Copy link
Contributor

@tiratano tiratano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@tiratano
Copy link
Contributor

tiratano commented Jan 9, 2017

근데 js 쪽은 생각을 못했었는데, ts만 해도 될까요?

Copy link
Contributor

@tiratano tiratano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음.. 저도 처음에 "영웅"으로 번역을 했다가 앞서 하신 분이 "히어로"라고 쓰셨길래 전부 replace 했었는데요. 어떤게 좋을까요?

@byungjune
Copy link
Contributor Author

@tiratano
(1) js의 튜토리얼은 별도로 없어서 ts만 해주시면 될 것 같습니다 : )
(ex) 'include ../../../_includes/_ts-temp' 이런 식으로 되어 있습니다)
(2) "히어로"는 제가 수정하도록 하겠습니다.

리뷰 감사합니다! 👍

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

- Translate the js/latest/tutorial/_data.json
- Change the translated word '영웅' to '히어로' about 'Hero'
@googlebot
Copy link

CLAs look good, thanks!

@byungjune byungjune merged commit 303b60a into angular:master Jan 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants