This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix ng style lazy one-time binding regression#11405
Closed
Narretz wants to merge 2 commits into
Closed
Conversation
This reverts commit 4c8d8ad, because it broke lazy one-time binding for object literals (introduced in c024f28) Fixes angular#11403
Contributor
|
Landed |
Narretz
added a commit
that referenced
this pull request
Mar 31, 2015
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
May 8, 2015
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
May 8, 2015
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no easy way to make the one-time binding work woth $watchCollection, so the easiest way is probably to revert the commit, as suggested by @lgalfaso