Skip to content

test(ivy): Add bazel flag to control building ViewEngine or Ivy#23680

Closed
mhevery wants to merge 3 commits into
angular:masterfrom
mhevery:ivy_switch
Closed

test(ivy): Add bazel flag to control building ViewEngine or Ivy#23680
mhevery wants to merge 3 commits into
angular:masterfrom
mhevery:ivy_switch

Conversation

@mhevery

@mhevery mhevery commented May 3, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@mhevery
mhevery requested review from IgorMinar and alexeagle May 3, 2018 17:41
@mary-poppins

mary-poppins commented May 3, 2018

Copy link
Copy Markdown

You can preview 940c778 at https://pr23680-940c778.ngbuilds.io/.

@mhevery mhevery added the target: major This PR is targeted for the next major release label May 3, 2018
@mary-poppins

mary-poppins commented May 3, 2018

Copy link
Copy Markdown

You can preview 0e8218b at https://pr23680-0e8218b.ngbuilds.io/.

alexeagle
alexeagle approved these changes May 3, 2018
View reviewed changes
Comment thread packages/core/BUILD.bazel Outdated

@alexeagle alexeagle May 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why backslashes??

@mhevery mhevery May 17, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

trotyl
trotyl reviewed May 4, 2018
View reviewed changes
Comment thread tools/bazel.rc Outdated

@trotyl trotyl May 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until switched to ViewEngine?

@IgorMinar IgorMinar May 10, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to Ivy"

@mhevery mhevery May 17, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

IgorMinar
IgorMinar suggested changes May 10, 2018
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct the docs

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 10, 2018
@ngbot

ngbot Bot commented May 10, 2018

Copy link
Copy Markdown

Hi @mhevery! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@mary-poppins

mary-poppins commented May 10, 2018

Copy link
Copy Markdown

You can preview f944bc0 at https://pr23680-f944bc0.ngbuilds.io/.

@mhevery mhevery removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 17, 2018
@mhevery
mhevery force-pushed the ivy_switch branch 2 times, most recently from 7ab54e1 to f1a9103 Compare May 18, 2018 18:42
@mary-poppins

mary-poppins commented May 18, 2018

Copy link
Copy Markdown

You can preview f1a9103 at https://pr23680-f1a9103.ngbuilds.io/.

@mary-poppins

mary-poppins commented May 18, 2018

Copy link
Copy Markdown

You can preview a714aeb at https://pr23680-a714aeb.ngbuilds.io/.

@mhevery

mhevery commented May 18, 2018

Copy link
Copy Markdown
Contributor Author

http://test/OCL:197204322:BASE:197204345:1526680326103:766c9bdf

@mary-poppins

mary-poppins commented May 22, 2018

Copy link
Copy Markdown

You can preview b0e3836 at https://pr23680-b0e3836.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes May 22, 2018
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the ci issues

@mary-poppins

mary-poppins commented May 22, 2018

Copy link
Copy Markdown

You can preview aa803d7 at https://pr23680-aa803d7.ngbuilds.io/.

@ngbot

ngbot Bot commented May 30, 2018

Copy link
Copy Markdown

Hi @mhevery! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@vicb vicb added the comp: ivy label May 31, 2018
mhevery
mhevery commented Jun 6, 2018
View reviewed changes

@mhevery mhevery left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhevery

mhevery commented Jun 25, 2018

Copy link
Copy Markdown
Contributor Author

superseded by #24056

@mhevery mhevery closed this Jun 25, 2018
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@trotyl trotyl trotyl left review comments
@alexeagle alexeagle alexeagle approved these changes
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mhevery @mary-poppins @alexeagle @IgorMinar @trotyl @vicb @googlebot