Skip to content

fix(compiler): error when reading compiled input transforms metadata in JIT mode #50600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crisbeto wants to merge 1 commit into from
Closed

fix(compiler): error when reading compiled input transforms metadata in JIT mode #50600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler/src/jit_compiler_facade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ function inputsMappingToInputMetadata(inputs: Record<string, string|[string, str
result[key] = {
bindingPropertyName: value[0],
classPropertyName: value[1],
transformFunction: value[2] || null,
transformFunction: value[2] ? new WrappedNodeExpr(value[2]) : null,
required: false,
};
}
Expand Down
32 changes: 30 additions & 2 deletions packages/core/test/render3/jit/declare_component_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import {ChangeDetectionStrategy, Component, Directive, ElementRef, forwardRef, Pipe, Type, ViewEncapsulation, ɵɵngDeclareComponent} from '@angular/core';

import {AttributeMarker, ComponentDef, ɵɵInheritDefinitionFeature, ɵɵNgOnChangesFeature} from '../../../src/render3';
import {AttributeMarker, ComponentDef, ɵɵInheritDefinitionFeature, ɵɵInputTransformsFeature, ɵɵNgOnChangesFeature} from '../../../src/render3';

import {functionContaining} from './matcher';

Expand Down Expand Up @@ -62,6 +62,30 @@ describe('component declaration jit compilation', () => {
});
});

it('should compile input with a transform function', () => {
const transformFn = () => 1;
const def = ɵɵngDeclareComponent({
type: TestClass,
template: '<div></div>',
inputs: {
minifiedClassProperty: ['bindingName', 'classProperty', transformFn],
}
}) as ComponentDef<TestClass>;

expectComponentDef(def, {
inputs: {
'bindingName': 'minifiedClassProperty',
},
inputTransforms: {
'minifiedClassProperty': transformFn,
},
declaredInputs: {
'bindingName': 'classProperty',
},
features: [ɵɵInputTransformsFeature],
});
});

it('should compile exportAs', () => {
const def = ɵɵngDeclareComponent({
type: TestClass,
Expand Down Expand Up @@ -486,7 +510,7 @@ type ComponentDefExpectations = jasmine.Expected<Pick<
ComponentDef<unknown>,
'selectors'|'template'|'inputs'|'declaredInputs'|'outputs'|'features'|'hostAttrs'|
'hostBindings'|'hostVars'|'contentQueries'|'viewQuery'|'exportAs'|'providersResolver'|
'encapsulation'|'onPush'|'styles'|'data'>>&{
'encapsulation'|'onPush'|'styles'|'data'|'inputTransforms'>>&{
directives: Type<unknown>[]|null;
pipes: Type<unknown>[]|null;
};
Expand All @@ -504,6 +528,7 @@ function expectComponentDef(
template: jasmine.any(Function),
inputs: {},
declaredInputs: {},
inputTransforms: null,
outputs: {},
features: null,
hostAttrs: null,
Expand All @@ -529,6 +554,9 @@ function expectComponentDef(
expect(actual.template).withContext('template').toEqual(expectation.template);
expect(actual.inputs).withContext('inputs').toEqual(expectation.inputs);
expect(actual.declaredInputs).withContext('declaredInputs').toEqual(expectation.declaredInputs);
expect(actual.inputTransforms)
.withContext('inputTransforms')
.toEqual(expectation.inputTransforms);
expect(actual.outputs).withContext('outputs').toEqual(expectation.outputs);
expect(actual.features).withContext('features').toEqual(expectation.features);
expect(actual.hostAttrs).withContext('hostAttrs').toEqual(expectation.hostAttrs);
Expand Down