Skip to content

Conversation

@splincode
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:
image

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from AndrewKushnir December 16, 2025 11:14
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: common Issues related to APIs in the @angular/common package labels Dec 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Dec 16, 2025
@JeanMeche
Copy link
Member

JeanMeche commented Dec 16, 2025

Having a replacer is known to have a perf impact on JSON.stringify. I would would recommend implementing a custom pipe for that rather than changing the current implemenation.

@JeanMeche
Copy link
Member

A short article from the v8 team about JSON.stringify that also confirms that with replacer there is a perf impact. https://v8.dev/blog/json-stringify

@JeanMeche JeanMeche closed this Dec 16, 2025
@splincode splincode deleted the patch-1 branch December 16, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants