fix(docs-infra): define missing win95 variables in aria autocomplete examples#69939
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): define missing win95 variables in aria autocomplete examples#69939erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…examples The retro-themed aria autocomplete examples style the clear button with var(--win95-gray), var(--win95-dark-gray), var(--win95-light), and var(--win95-shadow), but none of the three example stylesheets defines those custom properties. The variables resolve to nothing, so the button falls back to inherited theme colors — color: var(--win95-shadow) becomes the light-theme text color in dark mode, leaving the button unreadable. Define the four variables in :host of each example, matching the values already used by the sibling aria tree examples, so the clear button keeps its Windows 95 look in both light and dark themes.
angular-robot
Bot
added
the
area: docs-infra
14 tasks
JeanMeche
approved these changes
Jul 25, 2026
JeanMeche
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeds #69428
The retro-themed aria autocomplete examples style the clear button with var(--win95-gray), var(--win95-dark-gray), var(--win95-light), and var(--win95-shadow), but none of the three example stylesheets defines those custom properties. The variables resolve to nothing, so the button falls back to inherited theme colors — color: var(--win95-shadow) becomes the light-theme text color in dark mode, leaving the button unreadable.
Define the four variables in :host of each example, matching the values already used by the sibling aria tree examples, so the clear button keeps its Windows 95 look in both light and dark themes.
Before:
After: