refactor(core): Migrate more tests off fakeAsync - #69956
Conversation
| ); | ||
| fixture.detectChanges(); | ||
| tick(); | ||
| await fixture.whenStable(); |
There was a problem hiding this comment.
Q: Is detectChanges still necessary at this point since we are adding whenStable?
There was a problem hiding this comment.
I was debating with myself what to do with those animation related tests. ATM the changes were purely migrated by Gemini.
There was a problem hiding this comment.
Should we try to clean it up? We can do it later to improve the output for LLMs (even asking GTP 5.6, it has sometimes written to me using detectChanges instead of whenStable if I don't specify or it doesn't read the most modern tests generated in the project or Angular itself)
There was a problem hiding this comment.
Yeah I think cleaning up our unit tests would improve the agent outputs. Looking at some of the tests, not every detectChanges should be removed though we should be a bit careful when migrating them.
7256586 to
6e7c035
Compare
This will prevent to polute the agent context with outdated/bad practices.
2 participants
This will prevent to polute the agent context with outdated/bad practices.