refactor(router): add support for blocking router resources - #70293
Open
atscott wants to merge 2 commits into
Open
refactor(router): add support for blocking router resources#70293atscott wants to merge 2 commits into
atscott wants to merge 2 commits into
Conversation
atscott
force-pushed
the
resourcestackblocking
branch
9 times, most recently
from
August 20, 2026 16:30
d685fd5 to
08c24b3
Compare
Extends router resource integration to support blocking resources during navigation transitions. Resources declared in a route's `resources` function are blocking by default unless explicitly marked with `nonBlocking()`. Key behaviors include: - During the navigation transition, the router awaits the resolution of all blocking resources across target routes before proceeding to activation and completing navigation. - Blocking status is tracked via an effect on the underlying resource: if the resource settles with a value, the promise resolves; if the resource status becomes 'error', the promise rejects with the resource error, cancelling navigation and emitting `NavigationError`. - If a reused route is re-navigated to after a resource has errored (e.g., with `onSameUrlNavigation: 'reload'`), the router triggers `.reload()` on the underlying resource to retry the failed fetch. - All tracking effects are cleaned up upon resolution, rejection, or route injector destruction. - Supports both sync and async `resources` functions (returning `Promise<ResourceResult>`) as well as `rxResource`.
atscott
force-pushed
the
resourcestackblocking
branch
from
August 20, 2026 16:35
08c24b3 to
93857a5
Compare
atscott
marked this pull request as ready for review
August 20, 2026 16:40
leonsenft
approved these changes
Aug 20, 2026
|
|
||
| return Promise.all(resourceSetupPromises); | ||
| // TODO: wait for blocking resources | ||
| return Promise.all(resourceSetupPromises).then(() => Promise.all(blockingResourcePromises)); |
Contributor
There was a problem hiding this comment.
Do we need all setup promises to resolve before we await the blocking resource promises? Can't we just await them all?
return Promise.all([...resourceSetupPromises, ...blockingResourcePromises]);
Contributor
Author
There was a problem hiding this comment.
I nearly made this mistake today when giving it a final look. We have to wait for setup promises because only once those are resolved do we add to the blockingResourcePromises array.
| // Wrapped snapshot should be frozen at 'initial' during recovery loading | ||
| expect(wrapped.value()).toBe('initial'); | ||
|
|
||
| // Resource receives value while isLoading() remains true and status is 'loading' |
Contributor
There was a problem hiding this comment.
I don't completely follow this, why would it still be loading if the resource is resolved?
Contributor
Author
There was a problem hiding this comment.
This came from feedback internally. They have a custom streaming resource that has this behavior. It has a value after it receives the first value but stays in the loading state until the underlying rxjs observable is marked completed.
| expect(resourceRef.value()).toBe('rx loaded 123'); | ||
| }); | ||
|
|
||
| it('should unblock navigation when a resource emits a value even while remaining in loading state', async () => { |
Contributor
There was a problem hiding this comment.
I think this is the same use case I was confused about in the other test. Why does it remain loading?
atscott
force-pushed
the
resourcestackblocking
branch
from
August 20, 2026 18:14
b8fabc9 to
fab0f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends router resource integration to support blocking resources during navigation transitions.
Resources declared in a route's
resourcesfunction are blocking by default unless explicitly marked withnonBlocking(). Key behaviors include:NavigationError.onSameUrlNavigation: 'reload'), the router triggers.reload()on the underlying resource to retry the failed fetch.resourcesfunctions (returningPromise<ResourceResult>) as well asrxResource.