Update 1 - Install and Setup.md #528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'moduleId: module.id' is causing errors "url_resolver.js:248Uncaught TypeError: uri.match is not a function_split @ url_resolver.js:248getUrlScheme @ url_resolver.js:91componentModuleUrl @ ". Removed it from docs as the default angular-app does not contains an entry. I need to learn to consolidate small changes.
Collaborator
|
Hi @mukesh51! Thanks for the PRs! Can you combine all three into one, since they are small changes? Thanks! |
Contributor
Author
|
Hi @davideast based on your comment above, i created a combined PR for 3 PR's with following title (Combining PR #523,#526, #528). Hope this works!! |
davideast
pushed a commit
that referenced
this pull request
Sep 19, 2016
* Update 1 - Install and Setup.md Remove ModuleId: module.id, as WebPack takes care internally and is causing errors * Update @moduleName Update ModuleName to make it consistent * Update to Retrieve Data as Object The Tutorial needs to be in flow with "Install and Setup Page". Other pages needs to be looked into, which I'll do later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'moduleId: module.id' is causing errors
"url_resolver.js:248Uncaught TypeError: uri.match is not a function_split @
url_resolver.js:248getUrlScheme @ url_resolver.js:91componentModuleUrl @ ".
Removed it from docs as the default angular-app does not contains an entry. I need to learn to consolidate small changes.