Skip to content

docs: convert select/sidenav/slidetog/slider/snackb/sort to signals#33502

Merged
crisbeto merged 1 commit into
angular:mainfrom
msmallest:docs-opzl-select-sidenav-slider-slidet-snack-sort
Jul 8, 2026
Merged

docs: convert select/sidenav/slidetog/slider/snackb/sort to signals#33502
crisbeto merged 1 commit into
angular:mainfrom
msmallest:docs-opzl-select-sidenav-slider-slidet-snack-sort

Conversation

@msmallest

@msmallest msmallest commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

Converts the following components to use signals

Part of an effort to address this issue about compatibility with new defaults: #33443

  • Select
  • Sidenav
  • Slide Toggle
  • Slider
  • Snackbar
  • Sort Header

I also switched one loop from tracking by identity to an index. This was because the diffing algorithm was throwing template warnings about how the array had multiple non-unique instances between only two possible items that kept being pushed in.

PR Scope

Another 6 component types updated.

Extras

  1. Reference checklist gist: https://gist.github.com/msmallest/f77adb004b9e88c49b3a248bab90a26a?permalink_comment_id=6237249#gistcomment-6237249
  2. The next PR will be a smaller chunk since I didn't want to overload this PR. And the Table examples (not including the one with an open PR, thanks for that) IMO warrant its own PR that I will finish things off with. Well, there is still stuff like experimental and CDK, but I mean finishing off the typical components.
  3. edit: speaking of the point above, where would I find the pages to review the experimental examples? Do they have a docs page? I see use in the dev app, but I am not sure about the docs. I have since learned how the main pages of components reference particular examples by name, and there is the process of items in the index tending to by default be rendered in an Example page through a mechanism I am not familiarized with in the infra, but I am not sure where I would find any documentation embedded experimental examples.

@pullapprove pullapprove Bot requested review from andrewseguin and ok7sai July 8, 2026 02:14
@angular-robot angular-robot Bot added the area: docs Related to the documentation label Jul 8, 2026
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 8, 2026
@crisbeto crisbeto merged commit f4a0915 into angular:main Jul 8, 2026
34 of 36 checks passed
@crisbeto

crisbeto commented Jul 8, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto pushed a commit that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants