-
Notifications
You must be signed in to change notification settings - Fork 78
build: update bazel dependencies #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,8 @@ module(name = "rules_angular") | |
| # Prod dependencies | ||
| bazel_dep(name = "yq.bzl", version = "0.3.6") | ||
| bazel_dep(name = "bazel_lib", version = "3.7.1") | ||
| bazel_dep(name = "aspect_rules_js", version = "3.3.1") | ||
| bazel_dep(name = "aspect_rules_ts", version = "3.9.2") | ||
| bazel_dep(name = "aspect_rules_js", version = "3.4.0") | ||
| bazel_dep(name = "aspect_rules_ts", version = "3.10.0") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| bazel_dep(name = "bazel_skylib", version = "1.9.2") | ||
| bazel_dep(name = "jq.bzl", version = "0.6.1") | ||
| bazel_dep(name = "rules_nodejs", version = "6.7.5") | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,7 @@ node.toolchain( | |
| use_repo(node, "nodejs_toolchains") | ||
|
|
||
| # JS | ||
| bazel_dep(name = "aspect_rules_js", version = "3.3.1") | ||
| bazel_dep(name = "aspect_rules_js", version = "3.4.0") | ||
|
|
||
| pnpm = use_extension("@aspect_rules_js//npm:extensions.bzl", "pnpm") | ||
| pnpm.pnpm( | ||
|
|
@@ -80,7 +80,7 @@ npm.npm_translate_lock( | |
| use_repo(npm, "npm_rules_browsers") | ||
|
|
||
| # TS | ||
| bazel_dep(name = "aspect_rules_ts", version = "3.9.2") | ||
| bazel_dep(name = "aspect_rules_ts", version = "3.10.0") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext") | ||
| rules_ts_ext.deps( | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,12 +15,12 @@ local_path_override( | |
| path = "../", | ||
| ) | ||
|
|
||
| bazel_dep(name = "aspect_rules_js", version = "3.3.1") | ||
| bazel_dep(name = "aspect_rules_js", version = "3.4.0") | ||
|
|
||
| npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True) | ||
| use_repo(npm, "npm_rules_browsers") | ||
|
|
||
| bazel_dep(name = "aspect_rules_ts", version = "3.9.2") | ||
| bazel_dep(name = "aspect_rules_ts", version = "3.10.0") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext", dev_dependency = True) | ||
| use_repo(rules_ts_ext, "npm_rules_browsers_typescript") | ||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the upgrade of
aspect_rules_tsto3.10.0, theextextension has been deprecated in favor of the newtypescriptextension. Consider updating the extension usage on line 45 to usetypescriptinstead ofextto align with the latest API and avoid using deprecated features.