feat: use es2018 lib in tsconfig.json files

[christianliebel]

Update the lib property in tsconfig.json files of both schematics and the DevKit repo to es2018.

The ECMAScript 2018 feature set was finalized in January, so it seems reasonable to upgrade the libs as well. This is specifically interesting for the new Angular libs that are stuck at ECMAScript 2015 (!).

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[christianliebel]

I signed it!

[googlebot]

CLAs look good, thanks!

[clydin]

Please avoid changing files within the tests directory. They are generally setup to test specific scenarios.

Also, feat requires a scope. The commits should ideally be split into:

• feat(@schematics/angular): ...
• feat(@schematics/schematics): ...
• build: ... -> for the main tsconfig

[christianliebel]

@clydin I see. Thanks for your help. I’ll update the PR accordingly.

[christianliebel]

@clydin The tests looks better now. 👍 However, bazel-build seems to have a problem, probably because the Bazel TypeScript rules only support TS 2.6.x: https://github.com/bazelbuild/rules_typescript/blob/master/package.json#L27

What do you suggest? Should I file a new PR for rules_typescript to update their TS version?

[christianliebel]

I’ve created an additional PR (#870) that only bumps the lib to es2017, which should work using the current bazel build.

[filipesilva]

@alexeagle do you know why the bazel rules only support TS 2.6.x?

[clydin]

The devkit is built against 2.7. The problem appears to be that the lib type definitions are being sourced from the following (and 2.6 does not contain ES2018 definitions):

/home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular_devkit/external/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/typescript/lib/lib.es2018.d.ts

instead of the typescript version used to compile:

/home/circleci/ng/node_modules/typescript/lib/typescript.js

[clydin]

The error may stem from the following line which attempts to optimize the build time by re-using the library definitions from an existing project.

https://github.com/angular/devkit/blob/master/packages/angular_devkit/build_optimizer/BUILD#L32

[alexeagle]

Sorry @christianliebel , this got lost when we moved the code back over to the angular/angular-cli repo. Do you have time to re-base this commit on master over there?