This repository was archived by the owner on Apr 4, 2025. It is now read-only.
feat(@schematics/angular): update tsconfig.json libs to include es2017 #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the lib property in tsconfig.json for Angular libraries to include es2017.
|
Sorry @christianliebel , this got lost when we moved the code back over to the angular/angular-cli repo. Do you have time to re-base this commit on master over there? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, libraries created using the schematic only use the
es2015TypeScript lib. ECMAScript 2016, 2017 and 2018 have already been released. Interfaces introduced in these releases are unavailable in TypeScript without manually editing thetsconfig.json. This PR updates thelibproperty intsconfig.jsonfor Angular libraries to include at leastes2017. This is an intermediate solution, until #869 can be merged, which bumps the lib toes2018.