WIP: Use 1.24 Function syntax

[kevmoo]

Blocked on a new analyzer release - dart-lang/sdk#30239

Using alpha pkg/analyzer to see if travis gets happy
Looks like we need to update to use the 1.25.0-dev SDK, too!

[leonsenft]

Are we decided on what syntax to use when declaring function parameters? Both are valid:

void Function(E) eventHandler0<E>(void Function() handler) {}

void Function(E) eventHandler0<E>(void handler()) {}

I'm in favor of the latter as it's more concise, but I can understand the desire to be consistent with the former.

[matanlurey]

I think we decided always the former, the latter may be removed in a future version of Dart.

[kevmoo]

And encouraging the new syntax is goodness.

// No error, but this handle has no argument type
foo(void handler(int)) {};

// Does what you expect
foo(void Function(int)) {};

[leonsenft]

In that case there are some old style function parameters in these files you could update as well.

[kevmoo]

Yeah...but that's hard to regexp

I'd almost want a lint for that

[leonsenft]

LTGM, although some of the files still contain function typdefs. It won't let me comment on them directly but see *_control_acccesors.dart for void registerOnChange(ChangeFunction fn).

[kevmoo]

LTGM, although some of the files still contain function typdefs. It won't let me comment on them directly but see *_control_acccesors.dart for void registerOnChange(ChangeFunction fn).

Yeah, those are used across many files – left them for now until we decide what to do.