Make AccessToken method setTokenFromString public for HTML5 mode OFF #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good. This is blocking me too. |
Contributor
|
Should we include the built "dist/oauth-ng.js" in the PR's? |
Collaborator
|
Actually I don't know if it's common usage to include it or not. Any guess about the best practices in this? |
Contributor
Author
|
Thanks for your work. It help me a lot. |
andreareginato
added a commit
that referenced
this pull request
Oct 30, 2014
Make AccessToken method setTokenFromString public for HTML5 mode OFF
Contributor
|
@andreareginato looks like some PR's include the built file: #45 #40 Suppose if it's there, you know the tests were run. Would also make the merged master branch usable without having to go through a build step if you |
Collaborator
|
Makes sense to have it. Thanks @abuecker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When Angular is in HTML5 mode OFF, AccessToken.setTokenFromString(hash) must be add to the router.
Unfortunately, this method is private. Here is a proposal to make it work.
Kind regards,
Seb