fix(protractor): Replace $timeout with $interval #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreareginato
added a commit
that referenced
this pull request
Nov 3, 2014
fix(protractor): Replace $timeout with $interval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this one more time. I was a bad citizen and made my changes to the "dist/oauth-ng" file. Changes are now made to the correct source files.
Protractor E2E tests timeout and fail while waiting on all $timeouts()
to complete. Basically, protractor is waiting for the token to expire.
Thankfully, protractor does not wait until $interval() functions are
complete, since they are typically used for polling events. Using an
$interval with a count of 1 is essentially the same thing as calling
$timeout and the protractor tests pass.