Skip to content

Conversation

@AlexJF
Copy link
Contributor

@AlexJF AlexJF commented Nov 29, 2014

As it is, oauth-ng will continue to assume the saved token works even if it has already expired. Namely, the text in the directive will still ask for a Logout.

Now, I've seen in #17 that there are some plans for adding auto-renewal capaibilities. This sounds really cool. However, in the meanwhile, I suggest we put the directive back into a 'logged-off' status upon token expiration.

I've tested this in my web app and it appears to be working ok. After token expiration it now updates the directive to show 'Sign in' instead of 'Sign off' and we can request a renewal directly by clicking on it once instead of twice (without this, we'd need one click to make the directive logout and another to make it login again).

I'm not sure if we should actively destroy the token or not though. It works well in my workflow but perhaps the old token is needed for some renewal processes?

@AlexJF AlexJF force-pushed the directive-update-expired branch from 9d1b134 to cc3b644 Compare November 29, 2014 12:16
andreareginato added a commit that referenced this pull request Nov 29, 2014
Act on token expiration by deleting token and updating directive UI.
@andreareginato andreareginato merged commit 2ab8461 into angularjs-oauth:master Nov 29, 2014
@andreareginato
Copy link
Collaborator

In my flow I use the expired event to show a new page where I ask for a refresh. Anyway, your addition seems to be working together with the flow I've been using. Gonna merge and make some checks.

Thanks a lot @AlexJF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants