You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Release notes
Changes
Fixed format_html_content (and therefore format_html_file, which the linting of a nodejs-codeunit applies to
every html-file of that codeunit): text which belongs together was torn apart into several lines. The html-parser
hands out the text of an element in several pieces - an ampersand which does not begin a character-reference is
reported on its own and every character-reference is reported on its own - and the serializer wrote every piece
into a line of its own. An angular-template with @if (a != null && b != null) { therefore ended up with the two
ampersands on separate lines, which made the template unparsable, so the next build of that codeunit failed while
the build which caused it still succeeded. Tom & Jerry was affected as well and lost the spaces around the
ampersand. Pieces which belong together are joined into one text now, keeping the whitespace which was between
them.
ScriptCollectionCore got the functions docker_login and docker_login_with_retry (amount of attempts: 5 by
default) and login_to_defined_docker_registries, which every docker-login of ScriptCollection goes through, uses
the retrying one now. Reason: a docker login sporadically failed with net/http: TLS handshake timeout, which
aborted a whole build. That timeout is hardcoded in the registry-client of the docker-daemon and can not be
configured, so the only way to survive a temporarily slow registry is another attempt. Only timeout-errors are
retried, because an error with a permanent cause like wrong credentials would fail again in every further attempt.
For that, GeneralUtilities got retry_action_if, which retries an action only if the given predicate accepts the
thrown exception; retry_action delegates to it and behaves exactly as before.