Replace vscode-nls with @vscode/l10n - #65
Merged
GrahamStrickland merged 4 commits intoJul 23, 2026
Merged
Conversation
Closes #11 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vscode-nlsis in maintenance mode. It was only doing the{0}placeholder substitution here — the lookup was already hand-rolled againstpackage.nls*.json— so@vscode/l10n.t()drops straight into its place.Call sites deliberately stay off
vscode.l10n.t(). Two structural blockers:debugger.tsbundles this module and runs as a standalone adapter process (vscodeisexternalinclient/build.js), whererequire('vscode')throws.@vscode/l10nexists for exactly that case.formatEditor.ts:82passes the manifest's own%key%strings through verbatim — which a literal-message API cannot express.package.nls*.jsonstays regardless: 46 of its 76 keys localize the manifest. Moving runtime strings tol10n/bundle.l10n.*.jsonwould mean two message stores and duplicated translations for no user-visible gain, and only becomes worthwhile if #12 stops the webview deriving labels from the manifest.Also in here:
myLocalize.ts→messageBundle.ts. Committed as a pure rename (100% similarity), sogit log --followstill traces the full history.isolatedModulesset in both test tsconfigs, silencing a ts-jest warning introduced by thenode16move in Upgradevscode-languageclientv8 → v9 (+ matching server package) #10.Adapter bundle drops 59.0 KB → 53.6 KB. Client tests 88 → 98; server 78 unchanged. CI green on all three runners.
Bumps client to 1.4.2, server to 0.10.2.
Closes #11
🤖 Generated with Claude Code