[pull] master from kaldi-asr:master#412
Merged
pull[bot] merged 1 commit intoanniyanvr:masterfrom Jun 23, 2022
Merged
Conversation
…d scoring script (#4760) The mathematical equation is wrong. the calculations are correct but the naming and comments are not correct. The lists in lines 63 and 64 should be called fns (false negatives) and tns (true negatives), cause this is what they are. The comment in lines 66-69 was misleading, I fixed it. The variables in lines 77 and 78 should be called positives and negatives. The comments in lines 80-82 and lines 85-87 were misleading, I fixed them. In the end, the calculation now is compatible with the mathematical equations (you can see a reference in https://en.wikipedia.org/wiki/Confusion_matrix) The naming and comments are all correct. I also removed the variable "sorted_labels", it does not have any use here in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )