fix: address tool/plugin issues #11413, #11130, #11436#11465
Closed
lailoo wants to merge 2 commits into
Closed
Conversation
…malyco#11436 - fix(provider): remove non-standard JSON Schema fields (ref, $schema) for Gemini compatibility (anomalyco#11413) - fix(config): detect and report duplicate keys in config files with helpful error message (anomalyco#11130) - fix(file): add 100ms tolerance to file modification time check to prevent false positives (anomalyco#11436)
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
…11436 fixes - test(transform): add tests for Gemini schema sanitization removing ref and $schema fields - test(config): add tests for duplicate key detection in config files - test(file): add tests for FileTime.assert 100ms tolerance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three tool/plugin related issues:
#11413 - question tool schema causes 400 with Gemini
Problem: The
questiontool's JSON Schema contains non-standard fields (ref,$schema) from Zod's.meta()that Gemini API rejects.Fix: Updated
sanitizeGeminifunction intransform.tsto skip these non-standard fields when preparing schemas for Gemini.#11130 - plugins silently fail with bad syntax
Problem: Duplicate keys in
opencode.json(e.g., two"plugin"entries) are silently ignored, with the second value overwriting the first.Fix: Added duplicate key detection using
jsonc-parser'svisitfunction. Now throws a helpful error message suggesting array syntax:#11436 - file has been modified since it was last read
Problem: False positive errors when file mtime differs from read time by only a few milliseconds (e.g., 14ms difference) due to filesystem timestamp precision.
Fix: Added 100ms tolerance to the file modification time check in
time.ts.Testing
bun run typecheckpassesFiles Changed
packages/opencode/src/provider/transform.ts- Gemini schema sanitizationpackages/opencode/src/config/config.ts- Duplicate key detectionpackages/opencode/src/file/time.ts- File time tolerance