Skip to content

fix: #12032 parallelize sequential async operations with Promise.all#12032

Closed
MaxLeiter wants to merge 2 commits into
anomalyco:devfrom
MaxLeiter:max/02-03-perf-the-things
Closed

fix: #12032 parallelize sequential async operations with Promise.all#12032
MaxLeiter wants to merge 2 commits into
anomalyco:devfrom
MaxLeiter:max/02-03-perf-the-things

Conversation

@MaxLeiter

@MaxLeiter MaxLeiter commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The big win here is for MCPs - right now we fetch tools per MCP serially. There's no risk to doing this in parallel as listTools (should be) is side-effect free

How did you verify your code works?

It builds and runs as expected

Relates to: #7979

(it doesnt actually fix it, just related, but bot is making me)

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Hey! Your PR title perf: promise.all in various places doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@MaxLeiter MaxLeiter changed the title perf: promise.all in various places fix: #12032 parallelize sequential async operations with Promise.all Feb 3, 2026
@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@MaxLeiter

MaxLeiter commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

@rekram1-node for some reason I can't update the PR title; there's no edit button.

edit: opencode was able to do it for me by hitting the github API

@rekram1-node

Copy link
Copy Markdown
Collaborator

haha nice, the guidelines aren't strictly enforced it's mostly so I know who to ignore, I saw ur other pr and ur post on x so i was alraedy gonna review this

@rekram1-node

Copy link
Copy Markdown
Collaborator

/review

@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

lgtm

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR.

@github-actions github-actions Bot closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants