fix(provider): respect thinking toggle for Gemini models#12117
Closed
paulburkhardt wants to merge 2 commits into
Closed
fix(provider): respect thinking toggle for Gemini models#12117paulburkhardt wants to merge 2 commits into
paulburkhardt wants to merge 2 commits into
Conversation
The thinking toggle for Google/Gemini models was broken because `options()` unconditionally set `thinkingConfig.includeThoughts: true` regardless of whether the user enabled thinking. This meant: - Toggle OFF → thinking still enabled - Toggle ON → thinking enabled The thinking configuration should only come from the variant system when the user explicitly enables it via the toggle. Also removed the unconditional `reasoning.effort: "high"` default for Gemini 3 on OpenRouter for the same reason. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
6 tasks
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Gemini thinking toggle was busted. In transform.ts, the options() function always sent thinkingConfig: { includeThoughts: true } for Google/Vertex models - hardcoded, regardless of toggle state.
So turning thinking OFF did nothing. The API always got includeThoughts: true.
Fix: deleted the unconditional default. Now thinking config only gets set when you pick a variant (i.e., toggle it on). Same issue existed for Gemini 3 on OpenRouter with reasoning.effort: "high" - removed that too.
How did you verify your code works?
options() returns base provider options
variants() returns thinking configs for each effort level
When toggle is ON → variant merges in → thinking enabled
When toggle is OFF → no variant → now nothing sets thinking (before: options() still did)