fix(dev): add postinstall script to configure git symlinks on Windows#13398
Closed
mynameistito wants to merge 5 commits into
Closed
fix(dev): add postinstall script to configure git symlinks on Windows#13398mynameistito wants to merge 5 commits into
mynameistito wants to merge 5 commits into
Conversation
Contributor
Author
|
as discussed in discord, should not be changing git configs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/windows-symlinks.tsthat configures git symlinks on Windowspostinstallscript to automatically run afterbun install.d.tsfiles on WindowsProblem
On Windows,
git config core.symlinksdefaults tofalse, causing git to write symlinks as plain text files. TypeScript then reads the symlink path string as code, resulting in errors like:Solution
The postinstall script:
core.symlinksin git configRequirements
Closes #13397