fix: ensure installer PATH is exported and persistent#13404
Closed
omatheusmesmo wants to merge 1 commit into
Closed
fix: ensure installer PATH is exported and persistent#13404omatheusmesmo wants to merge 1 commit into
omatheusmesmo wants to merge 1 commit into
Conversation
- Adds mkdir and touch to guarantee config file existence before grep - Exports PATH to the current shell session for immediate use - Provides a source instruction fallback if the command is not yet hashed - Fixes anomalyco#13403
6 tasks
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13403
This PR improves the installation script to handle environments where shell configuration files (like
.bashrc) might not exist or where thePATHisn't updated in the current session after installation.Changes made:
mkdirandtouchto guarantee the target config file exists before attempting togrepor append to it.export PATHwithin the script so theopencodecommand can be used in the same session that ran the installer.sourceinstruction for the user.These changes work because they address both disk persistence and current shell memory, preventing the "command not found" error on minimal Linux distros (like Debian/Armbian) immediately after a successful install.
How did you verify your code works?
Tested on Debian Bookworm (Orange Pi 5) via SSH:
opencodewas not found.install.sh.opencode -vwithout restarting the terminal or manual sourcing.Terminal session: