feat: add chat_template_kwargs for nvidia nim provider#13583
Closed
andriixyz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
| status: "active", | ||
| options: {}, | ||
| headers: {}, | ||
| }) as any |
Contributor
There was a problem hiding this comment.
possible to avoid 'any' ?
see style preferences
andriixyz
force-pushed
the
feat/add-thinking-support-for-nvidia
branch
from
February 15, 2026 12:18
cdcf6de to
3929074
Compare
Contributor
|
lgtm |
Contributor
upon further review this comment is irrelevant, as the original file has 'any' typing to begin with https://github.com/anomalyco/opencode/blob/dev/packages/opencode/test/provider/transform.test.ts |
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
|
What happened with this PR, this feature is key! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the official documentation for nvidia nim it is possible to set
"enable_thinking":true,"clear_thinking":falseinside the request, this PR adds support of thatResolves #13584.
https://build.nvidia.com/z-ai/glm5/modelcard
Example of code: