feat(id): brand WorkspaceID through Drizzle and Zod schemas#16964
Merged
kitlangton merged 7 commits intodevfrom Mar 11, 2026
Merged
feat(id): brand WorkspaceID through Drizzle and Zod schemas#16964kitlangton merged 7 commits intodevfrom
kitlangton merged 7 commits intodevfrom
Conversation
2 tasks
kitlangton
force-pushed
the
feat/branded-message-id
branch
from
3b865e2 to
2ca9fb5
Compare
kitlangton
force-pushed
the
feat/branded-workspace-id
branch
2 times, most recently
from
d5c8a5e to
38743b8
Compare
kitlangton
changed the title
Base automatically changed from
feat/branded-message-id
to
feat/branded-session-id
March 11, 2026 20:45
kitlangton
force-pushed
the
feat/branded-session-id
branch
from
b38a9c1 to
860610c
Compare
kitlangton
force-pushed
the
feat/branded-workspace-id
branch
from
38743b8 to
672c2ed
Compare
Introduce Effect branded ProjectID type into Drizzle table columns and Zod schemas so the brand flows through z.infer automatically. Adds ProjectID.zod helper to bridge Effect brands into Zod, eliminating manual Omit & intersect type overrides.
- Remove unnecessary WorkspaceInfoType alias import - Use input.projectID instead of config.projectID in workspace create - Compare against ProjectID.global instead of String coercion in test
Same pattern as ProjectID/SessionID: add branded MessageID type with
MessageID.zod and MessageID.ascending() helpers, type Drizzle columns
with $type<MessageID>(), and replace all Identifier.schema("message")
and z.string() usages. Brand flows through z.infer automatically.
- Replace MessageID.make(Identifier.ascending("message")) with MessageID.ascending()
- Remove as any casts in import.ts by destructuring out column-stored fields
- Revert unrelated account.ts changes
The rebase dropped the MessageID test fix. Tests were using plain
strings ("test-id", "parent-id") which fail zod's startsWith("msg")
validation.
kitlangton
force-pushed
the
feat/branded-workspace-id
branch
from
672c2ed to
0a80b9f
Compare
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 19, 2026
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #16956 (MessageID).
Summary
WorkspaceIDtype with.make(),.ascending(), and.zodstaticsWorkspaceIDthrough Drizzle columns (WorkspaceTable.id,SessionTable.workspace_id),WorkspaceContext, and server boundariesWorkspaceID.make()Test plan
bun turbo typecheckpassesbun testpasses