fix(app): guard comment accessor in message timeline#17126
Merged
Hona merged 1 commit intoanomalyco:devfrom Mar 12, 2026
Merged
fix(app): guard comment accessor in message timeline#17126Hona merged 1 commit intoanomalyco:devfrom
Hona merged 1 commit intoanomalyco:devfrom
Conversation
During reactive store updates, the <Index> comment accessor can briefly
return undefined before cleanup. Wrap with <Show when={comment()}> to
prevent TypeError on .path access.
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents a runtime crash in the session message timeline by guarding access to a comment object that can temporarily be undefined during SolidJS reactive updates.
Changes:
- Wrap each comment bubble’s rendering in
<Show when={comment()}>to avoid reading properties from anundefinedcomment. - Update comment bubble internals to reference the
<Show>-provided accessor (c()) rather than the unguarded memo value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 19, 2026
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 20, 2026
balcsida
pushed a commit
to balcsida/opencode
that referenced
this pull request
Mar 24, 2026
balcsida
pushed a commit
to balcsida/opencode
that referenced
this pull request
Apr 8, 2026
RobertWsp
pushed a commit
to RobertWsp/opencode
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comment()accessor with<Show>in the message timeline comment bubbles to preventTypeError: Cannot read properties of undefined (reading 'path').Root cause
The
<Index each={comments()}>accessor can briefly returnundefinedduring SolidJS reactive batch updates when the underlyingsync.data.part[messageID]store changes. ThecreateMemo(() => commentAccessor())captures thisundefined, andcomment().paththrows.Stack trace