fix(windows): restore /editor support on Windows#17146
Merged
Hona merged 1 commit intoanomalyco:devfrom Mar 16, 2026
Merged
Conversation
Member
|
/review |
Contributor
|
lgtm |
Member
|
later we might have issues with spaces in EDITOR or file name, but for now this is better |
ConanXu-math
pushed a commit
to ConanXu-math/opencode
that referenced
this pull request
Mar 17, 2026
This was referenced Mar 18, 2026
AvatarGanymede
pushed a commit
to AvatarGanymede/opencode-dev
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17117
Type of change
What does this PR do?
This fixes
/editorbeing unavailable on Windows.I referred to the Node.js
child_processdocumentation for Windows commandspawning behavior:
https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows
According to that documentation,
.batand.cmdfiles may need to be launchedthrough a shell on Windows. In practice, commands such as
$env:EDITOR = "code --wait"could hang or fail to launch correctly when spawned without shell support.
This PR enables
shellwhen launching the editor on Windows, so editor commandslike
code --waitcan be started correctly there and/editorworks again.How did you verify your code works?
Tested locally on Windows by running
/editorand confirming:Screenshots / recordings
Included below.



Then close code.
Checklist