fix: rebase onto upstream/dev — Effect-ification integration (Phase 4)#19
Merged
fix: rebase onto upstream/dev — Effect-ification integration (Phase 4)#19
Conversation
…ons (#17064) Co-authored-by: jquense <jquense@ramp.com>
… in API call errors (#17748)
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Remove duplicate isActiveOrgChoice in account.ts (upstream already has it). Update STATUS.md to reflect Phase 4 upstream sync completion.
ea42ce1 to
34977e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates all remaining upstream changes by replaying 41 upstream commits on top of
origin/dev, closing the upstream gap entirely:dev(41 upstream + 3 integration fixes)Conflict resolutions
skill.ts: Kept upstream'sSkillServiceEffect pattern, re-added ourMeta/Loadedtypes andmeta()method on toppty-session.test.ts: Kept our improvedwaitForBus(event-driven) over upstream's pollingwaitllm.ts: Resolved trivial field-ordering conflict, removed duplicatepermissionfieldcopilot.ts,provider.ts: Accepted ours (already backported)config.ts,prompt.ts,line-comment*: Used already-resolved versions from initial rebase passaccount.ts: Removed duplicateisActiveOrgChoice(upstream already had it)Verification
bun typecheck— 0 errors across all 13 packagesbun test— 1430 pass, 0 fail, 8 skipUpstream contributors integrated
0afeaea)Integration fix commits (by @e6qu)
749fd712fbf8c634977e5Test plan
bun typecheck— 0 errorsbun test— 1430 pass, 0 fail