feat(tui): store/restore shell commands in message history#2007
Closed
yihuikhuu wants to merge 1 commit into
Closed
feat(tui): store/restore shell commands in message history#2007yihuikhuu wants to merge 1 commit into
yihuikhuu wants to merge 1 commit into
Conversation
Member
|
this was actually intentional on my end; do you think they belong in history? i went back and forth on it |
Contributor
Author
|
Ah fair enough. Thinking about it a bit more, it might pollute the history to add them in there. It initially felt a bit odd - muscle memory kicked in and I pressed up to replay the command and ended up sending my previous message instead. For reference, I just checked the behaviour on Claude Code/Gemini:
|
Contributor
Author
|
Happy to close this since this was an intentional decision though, maybe can revisit if there is similar feedback by others |
Member
|
yeah, i'm inclined to leave the behavior as is until convinced otherwise by lots of requests |
Contributor
Author
|
No worries, lets close this off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2006
before:
noshellhistory.mov
after:
withshellhistory.mov